Fix API key cookie authentication (#568) #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview b47f3c2 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-569.surge.sh |
|
I can only work on this on fridays, but yes, my locally published snapshot fixes the issue. I will look into the ITs to see if I can create/adapt one. Edit: I can't get the ITs to run locally on my machine, neither using the classic nor the reactive profile. That makes developing an IT a little bit hard. Any hints? |
|
Can you investigate this generated file? |
fjtirado
reviewed
Nov 30, 2023
...e/src/main/java/io/quarkiverse/openapi/generator/providers/ApiKeyAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
|
I have checked the generated file and everything looks fine. Therefore, I decided to have a look at the dependency injection. While reading the Quarkus DI guide I discovered the option to prevent ArC from removing configured beans. After adding the following line to my local application config, I was able to run the tests: I have no idea why the rest client is removed per default on my local test setup, as it works fine whtin the GitHub pipeline. However, with this little hack I could verify my test works out by having a failure without the fix and a success with the fix. |
ricardozanini
approved these changes
Dec 1, 2023
hbelmiro
reviewed
Dec 9, 2023
|
The automated build failed due to an error with the new integration test. The issue arises due to availability of two REST implementations (classic v/s reactive). This again is because of the default activated classic maven profile. During the development of the integration test I asked myself if the classic profile should be acivated per default. Since the integration tests are designed to explicitly activate it when invoking the classic integraion tests I would recommend disabling the default behavior. |
|
@ssternal we need to run tests with RESTEasy Classic and Reactive, unless in rare situations. PTAL at https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/CONTRIBUTING.md#resteasy-reactive-and-resteasy-classic. To fix the failing tests you need to remove the dependencies from the test pom.xml. Those dependencies are handled by the parent module. You can use https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/integration-tests/simple/pom.xml as an example. |
nmirasch
reviewed
Jan 19, 2024
Co-authored-by: nmirasch <neus.miras@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...tication/src/test/java/io/quarkiverse/openapi/generator/it/WiremockCookieAuthentication.java
Fixed
Show fixed
Hide fixed
nmirasch
reviewed
Jan 19, 2024
...tication/src/test/java/io/quarkiverse/openapi/generator/it/WiremockCookieAuthentication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: nmirasch <neus.miras@gmail.com>
hbelmiro
approved these changes
Jan 19, 2024
...tication/src/test/java/io/quarkiverse/openapi/generator/it/WiremockCookieAuthentication.java
Dismissed
Show dismissed
Hide dismissed
|
@all-contributors add @nmirasch for code. |
|
I've put up a pull request to add @nmirasch! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568:
Replaces access to read-only cookies using mutable headers during API key cookie authentication. This works around a potential
UnsupportedOperationException.