Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new property "config-key" and use configKey instead openApiSpecId on templating #457

Merged
merged 11 commits into from
Sep 7, 2023
Merged

Conversation

mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Sep 3, 2023

This pull request try to fix the issue #363

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mcruzdev mcruzdev marked this pull request as ready for review September 4, 2023 11:48
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contributions! I have a few observations if you don't mind reviewing.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we are getting in there! 👯

…rator/deployment/codegen/OpenApiGeneratorCodeGenBase.java

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mcruzdev. Good job!
I left a few picky comments and it seems you forgot to create some tests (see the comments).

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mcruzdev and others added 4 commits September 7, 2023 19:03
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro merged commit b156700 into quarkiverse:main Sep 7, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 7, 2023
@hbelmiro hbelmiro linked an issue Oct 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config-Request: customize configKey name
4 participants