Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extension user to include logging-manager on management interface into openApi *swagger) #348

Closed
alex-kovalenko1982 opened this issue Dec 9, 2024 · 3 comments · Fixed by #350
Assignees
Labels
enhancement New feature or request

Comments

@alex-kovalenko1982
Copy link

it is a follow-up issue of the #200

logging-manager works ok on management port and path.

however, there is a condition in the processor that prevents logging-manager endpoints to be added into the openapi/swagger.

return !managementConfig.enabled && shouldInclude(launchMode, loggingManagerConfig);

having the special config property to include/exclude logging-manager from the openApi it seems ok to remove the condition !managementConfig.enabled mentioned in the above line. thus, extension user can decide whether to include it in openApi or not independent on management interface configuration.

@melloware melloware added the enhancement New feature or request label Dec 9, 2024
melloware added a commit to melloware/quarkus-logging-manager that referenced this issue Dec 9, 2024
@melloware
Copy link
Contributor

@all-contributors add @alex-kovalenko1982 for idea

Copy link
Contributor

@melloware

I've put up a pull request to add @alex-kovalenko1982! 🎉

@melloware
Copy link
Contributor

Deployed 3.3.1

@melloware melloware self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants