Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the 'loading' bubbles in chatbot samples #892

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Hide the 'loading' bubbles in chatbot samples #892

merged 2 commits into from
Sep 16, 2024

Conversation

jmartisk
Copy link
Collaborator

replaces #890

@dependabot
Bump org.mvnpm:wc-chatbot from 0.1.2 to 0.2.0
d9ff206 
Bumps [org.mvnpm:wc-chatbot](https://github.com/yishiashia/wc-chatbot) from 0.1.2 to 0.2.0.
- [Release notes](https://github.com/yishiashia/wc-chatbot/releases)
- [Commits](yishiashia/wc-chatbot@v0.1.2...v0.2.0)

---
updated-dependencies:
- dependency-name: org.mvnpm:wc-chatbot
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@jmartisk jmartisk requested a review from a team as a code owner September 16, 2024 05:19
@jmartisk jmartisk mentioned this pull request Sep 16, 2024
Closed
geoand
geoand approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@geoand geoand requested a review from cescoffier September 16, 2024 09:53
cescoffier
cescoffier approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little known fact: Did you know that this version will let us handle streaming (with a bit of javascript, but nothing too hard :-)

@geoand
Copy link
Collaborator

geoand commented Sep 16, 2024

That's great!

@geoand geoand merged commit 20ed9ff into quarkiverse:main Sep 16, 2024
12 checks passed
@jmartisk jmartisk deleted the hide-all-loading branch September 16, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartisk @geoand @cescoffier