Support for Tools in Vertex AI Gemini #1169
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
changed the title
|
Thanks for looking into it @sberyozkin! There are no obvious error I see, but only some proper testing will show the way :) |
|
@geoand Sure, I'll experiment |
sberyozkin
force-pushed
the
gemini_tools
branch
from
da346db to
c7edcc5
Compare
sberyozkin
force-pushed
the
gemini_tools
branch
from
c7edcc5 to
5987cb8
Compare
|
I've prototyped the integration test, with a single Tool for now, and it fails, so the next task for early 2025 is to fix it :-) and then make it work for 2 tools |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @geoand, I've done a lot of copying from similar Ollama Tools support code and I have to admit I'm not sure I'm on the right track, Ollama code has some similarities but the the code there is much more involved compared to the Gemini one which does not offer non-streaming support yet.
Can you please have a quick look tomorrow and point to some obvious errors, before I attempt to test it :-) ?