Merge pull request #1028 from quarkiverse/llama3-missing

Add missing llama3-java module
quarkiverse · Oct 31, 2024 · d4a91a0 · d4a91a0
2 parents 42dacc6 + f6a167d
commit d4a91a0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/.github/workflows/build-pull-request.yml b/.github/workflows/build-pull-request.yml
@@ -126,7 +126,17 @@ jobs:
 
       - name: Run tests of ${{ matrix.module }} with JDK ${{ matrix.java }}
         run: |
-          cd ${{ matrix.module }} && ../mvnw -B verify -Dci=true -Dno-format -ntp    
+          cd ${{ matrix.module }} && ../mvnw -B verify -Dci=true -Dno-format -ntp
+
+      # Build Llama3.java if JDK >= 22. See https://x.com/tjake/status/1849141171475399083?t=EpgVJCPLC17fCXio0FvnhA&s=19 for the reason
+      - name: Build Llama3-java extension
+        if: ${{ matrix.java >= 22 }}
+        run: |
+          ./mvnw -B clean install -DskipTests -Dno-format -ntp -f model-providers/llama3-java/pom.xml
+
+      - name: Run tests of ${{ matrix.module }} with JDK ${{ matrix.java }}
+        run: |
+          cd ${{ matrix.module }} && ../mvnw -B verify -Dci=true -Dno-format -ntp              
 
 
   native-tests:

diff --git a/model-providers/pom.xml b/model-providers/pom.xml
@@ -38,6 +38,15 @@
                 <module>jlama</module>
             </modules>
         </profile>
+        <profile>
+            <id>jdk22-plus</id>
+            <activation>
+                <jdk>[22,)</jdk>
+            </activation>
+            <modules>
+                <module>llama3-java</module>
+            </modules>
+        </profile>
     </profiles>