Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevUI: add report files #95

Merged
merged 1 commit into from
Oct 4, 2024
Merged

DevUI: add report files #95

merged 1 commit into from
Oct 4, 2024

Conversation

melloware
Copy link
Contributor

image

image

@melloware melloware requested a review from a team as a code owner October 4, 2024 20:56
@melloware
Copy link
Contributor Author

cc @nderwin

for (ReportRootBuildItem root : reportRoots) {

for (ReportRootBuildItem reportRoot : reportRoots) {
Path startDir = Paths.get(reportRoot.getPath()); // Specify your starting directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check if the path is inside the project directory? Not sure if this may become a security issue

Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Member

gastaldi commented Oct 4, 2024

Can we click on a report and edit the XML contents too? That would be awesome with live reload

@melloware
Copy link
Contributor Author

One step at a time!

@melloware melloware merged commit 7af6139 into main Oct 4, 2024
1 check passed
@melloware melloware deleted the hot-deployment branch October 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants