Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for using style templates #118

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

nderwin
Copy link
Contributor

@nderwin nderwin commented Oct 14, 2024

  • Fixes Test: Migrate Template Styles Example #116
  • added an example report that uses styles
  • fixed the processor to not attempt to compile the styles, but instead just copy them to the output directory
  • added some constants for media types
  • use constants for header names were possible
  • added a new REST service to wrap all the different output formats for the styled report
  • centralized the export methods so they could be reused between the REST endpoints

Signed-off-by:Nathan Erwin nathan.d.erwin@gmail.com

* Fixes quarkiverse#116
* added an example report that uses styles
* fixed the processor to not attempt to compile the styles, but instead just copy them to the output directory
* added some constants for media types
* use constants for header names were possible
* added a new REST service to wrap all the different output formats for the styled report
* centralized the export methods so they could be reused between the REST endpoints

Signed-off-by:Nathan Erwin <nathan.d.erwin@gmail.com>
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

@melloware melloware marked this pull request as ready for review October 14, 2024 12:45
@melloware melloware requested a review from a team as a code owner October 14, 2024 12:45
@melloware melloware merged commit 2df53d2 into quarkiverse:main Oct 14, 2024
1 check passed
@nderwin
Copy link
Contributor Author

nderwin commented Oct 14, 2024

Oh, I thought I had this still as a draft... oops.

@melloware
Copy link
Contributor

You did but I merged it anyway wanted to test it. Looks good to me.

@melloware
Copy link
Contributor

Ahh I see you didn't actually write an Integration Test for it.

@nderwin nderwin deleted the bugfix/116 branch October 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: Migrate Template Styles Example
2 participants