Make testcontainer startup timeout configurable, default = 120s #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Jun 11, 2024
|
I see you decided against making it match the startup timeout? Just re-using the existing startupTimeout variable? |
melloware
requested changes
Jun 11, 2024
|
Yes, I decided to go with a duration value, because the CLAMD_STARTUP_TIMEOUT env does not look like a duration counter. Maybe you can help me finding the unit of this variable? Which formatter command do you mean? |
|
Ahh, found where duration is defined: https://github.com/Cisco-Talos/clamav-docker/blob/3b5c1b28579cd3c6d9dbf10c8cbaf6576b78f09a/clamav/1.3/debian/scripts/docker-entrypoint.sh#L71C4-L71C11 . Okay, will iterate. :) |
melloware
approved these changes
Jun 11, 2024
|
I will publish this tomorrow to Maven Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41