make workbench compatible with latest version of pysd #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes workbench compatible with latest version of pysd
EwoutH
reviewed
Dec 15, 2023
| Python model "Teacup.py" | ||
| Translated using PySD version 0.9.0 | ||
| Python model 'Teacup.py' | ||
| Translated using PySD |
There was a problem hiding this comment.
Maybe keep the (updated) version number here, for historical reference.
|
Great effort! Unfortunately I don't have the expertise to review this in depth. Maybe add the most important points that are changed (and users should thus possibly change in their models ) to the PR message. |
|
er veranderd niets aan de buitenkant. Er zijn alleen wat kleine interne veranderingen omdat dingen verschoven waren in pysd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes workbench compatible with latest version of pysd