test for get_results and categorical fix #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
approved these changes
Apr 3, 2023
| @@ -306,6 +309,14 @@ def get_results(self): | |||
| _logger.warning("some experiments have failed, returning masked result arrays") | |||
| results[k] = v | |||
|
|
|||
| for name, dtype in zip(self.columns, self.dtypes): | |||
| try: | |||
| if dtype == "object": | |||
There was a problem hiding this comment.
Please add a quick comment why this is done
quaquel
added a commit
that referenced
this pull request
Apr 24, 2023
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.
quaquel
added a commit
that referenced
this pull request
Apr 24, 2023
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.
EwoutH
pushed a commit
that referenced
this pull request
Jun 18, 2023
#241 ensured that categorical uncertainties were properly handled in the experiment dataframe. The general introduction used an outdated fix for the same problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds additional test for get_results (for completing #232) and fixes #236