Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace depreciated shade keyword in Seaborn kdeplot with fill #169

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Replace depreciated shade keyword in Seaborn kdeplot with fill #169

merged 1 commit into from
Sep 19, 2022

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented Sep 12, 2022 •
edited
Loading

I noticed in the CI that since the seaborn v0.12 release the shade keyword in kdeplot is depreciated, and will be removed in seaborn v0.14. This commit replaces it with the new keyword fill.

/opt/hostedtoolcache/Python/3.10.6/x64/lib/python3.10/site-packages/seaborn/axisgrid.py:1507: FutureWarning:
`shade` is now deprecated in favor of `fill`; setting `fill=True`.
This will become an error in seaborn v0.14.0; please update your code.

@EwoutH
Replace depreciated "shade" keyword in seaborn map_diag
ac0ae0c 
I noticed in the CI that since the seaborn v0.12 release the `shade` keyword is depreciated, and will be removed in seaborn v0.14. This commit replaces it with the new keyword `fill`.
@EwoutH EwoutH added this to the 2.3.0 milestone Sep 12, 2022
@EwoutH EwoutH requested a review from quaquel September 12, 2022 15:00
@EwoutH EwoutH changed the title Replace depreciated "shade" keyword in seaborn kdeplot Replace depreciated shade keyword in Seaborn kdeplot with fill Sep 12, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.996% when pulling ac0ae0c on seaborn-shade-depr into b25f9bd on master.

@EwoutH
Copy link
Collaborator Author

EwoutH commented Sep 19, 2022

Retriggered the one CI job that failed, and it passed. I confirmed the depreciation notice is gone.

@quaquel Could you review/approve this PR?

@quaquel quaquel merged commit da65c52 into master Sep 19, 2022
@EwoutH EwoutH deleted the seaborn-shade-depr branch September 26, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaquel quaquel Awaiting requested review from quaquel

Assignees
No one assigned
Labels
dependency
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EwoutH @coveralls @quaquel