Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custatevec support v6 #600

Merged
merged 18 commits into from
Apr 13, 2023
Merged

Conversation

jaeyoo
Copy link
Contributor

@jaeyoo jaeyoo commented Apr 4, 2023

Add finding cuquantum library shared file & header file automatically

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Apr 4, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Apr 4, 2023
@jaeyoo
Copy link
Contributor Author

jaeyoo commented Apr 13, 2023

FYI, CUQUANTUM_ROOT is standard from NVIDIA official doc.

Also, if it's not set, the Bazel rule cuquantum_configure() finds the custatevec.h and libcustatevec.so file.

Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bundle of questions and formatting nits.

third_party/cuquantum/BUILD.tpl Outdated Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Outdated Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Outdated Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Show resolved Hide resolved
third_party/cuquantum/cuquantum_configure.bzl Show resolved Hide resolved
third_party/BUILD Outdated Show resolved Hide resolved
@jaeyoo jaeyoo requested a review from 95-martin-orion April 13, 2023 18:05
Copy link
Collaborator

@sergeisakov sergeisakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@95-martin-orion 95-martin-orion merged commit bebf0ad into quantumlib:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants