Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtime type checking in symmetry_conserving_bravyi_kitaev #785

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Improve runtime type checking in symmetry_conserving_bravyi_kitaev #785

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3865956
Improve runtime type checking in symmetry_conserving_bravyi_kitaev
kwkbtr Jun 22, 2022
fdfe267
Merge branch 'master' into fix_scbk
ncrubin Jul 18, 2022
1f8a34c
Merge branch 'master' into fix_scbk
ncrubin Aug 9, 2022
51d01f7
Merge branch 'master' into fix_scbk
kwkbtr Dec 6, 2022
013b508
Merge branch 'master' into fix_scbk
kwkbtr May 29, 2023
bf9986e
Merge branch 'master' into fix_scbk
mpharrigan Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/openfermion/transforms/opconversions/remove_symmetry_qubits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ def symmetry_conserving_bravyi_kitaev(fermion_hamiltonian, active_orbitals,
with an arbitrary number of fermions.
"""
# Catch errors if inputs are of wrong type.
if type(fermion_hamiltonian) is not FermionOperator:
if not isinstance(fermion_hamiltonian, FermionOperator):
raise ValueError(
"Supplied operator should be an instance of FermionOperator class")
if type(active_orbitals) is not int:
if not isinstance(active_orbitals, int):
raise ValueError("Number of active orbitals should be an integer.")
if type(active_fermions) is not int:
if not isinstance(active_fermions, int):
raise ValueError("Number of active fermions should be an integer.")

# Arrange spins up then down, then BK map to qubit Hamiltonian.
Expand Down