Make implicit Optional type hints in Quantum Engine PEP 484 compliant #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6640 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1067 1067
Lines 91550 91550
=======================================
Hits 89549 89549
Misses 2001 2001 ☔ View full report in Codecov by Sentry. |
senecameeks
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
maffoo
approved these changes
Jun 7, 2024
|
This is generated code, right? Would it help to regenerate it at some point with a newer gapic version? |
pavoljuhas
pushed a commit
to pavoljuhas/Cirq
that referenced
this pull request
Jun 26, 2024
…quantumlib#6640) * implicit optional type hints PEP 484 compliant * rm type ignore * add type ignore back * mypy
pavoljuhas
pushed a commit
to pavoljuhas/Cirq
that referenced
this pull request
Jun 26, 2024
…quantumlib#6640) * implicit optional type hints PEP 484 compliant * rm type ignore * add type ignore back * mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6638