Allow passing None to AbstractCircuit.from_moments
#6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6637 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1067 1067
Lines 91550 91551 +1
=======================================
+ Hits 89549 89550 +1
Misses 2001 2001 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
approved these changes
Jun 7, 2024
senecameeks
requested changes
Jun 7, 2024
| for m in moments: | ||
| if isinstance(m, Moment): | ||
| yield m | ||
| elif isinstance(m, AbstractCircuit): | ||
| yield Moment(m.freeze().to_op()) | ||
| else: | ||
| elif m is not None: |
There was a problem hiding this comment.
Should this be elif m to encapsulate the empty [] case as well? Since None is expected to replace the [] case, I'd expect them to yield the same output. WDYT?
There was a problem hiding this comment.
I didn't intend for None to replace []. The former would be skipped, while the latter would produce an empty moment in the circuit.
There was a problem hiding this comment.
Thanks for clarifying!
senecameeks
approved these changes
Jun 7, 2024
| for m in moments: | ||
| if isinstance(m, Moment): | ||
| yield m | ||
| elif isinstance(m, AbstractCircuit): | ||
| yield Moment(m.freeze().to_op()) | ||
| else: | ||
| elif m is not None: |
There was a problem hiding this comment.
Thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing circuits with
Circuit.from_momentswe often want to conditionally include a moment and we often end up with awkward expressions like:This PR would allow us to pass
Noneas an arg tofrom_momentsin which case that arg would be skipped and not included in the circuit (not even as an empty moment). The above code can then be written more clearly as: