Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve replace_version tool and development wheels #6626

Merged

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented May 31, 2024

  • Make dev_tools/modules.py replace_version update also the
    version expected in unit tests

  • Skip type check in the new test-only source files

  • Update dev_tools/packaging/produce-package.sh to use the replace_version
    utility when building development wheels

@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners May 31, 2024 08:16
@pavoljuhas pavoljuhas requested a review from maffoo May 31, 2024 08:16
@CirqBot CirqBot added the size: S 10< lines changed <50 label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (6709046) to head (3a3114c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6626   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1061     1067    +6     
  Lines       91455    91518   +63     
=======================================
+ Hits        89454    89517   +63     
  Misses       2001     2001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas enabled auto-merge (squash) May 31, 2024 22:27
@pavoljuhas pavoljuhas merged commit 16de069 into quantumlib:main May 31, 2024
34 checks passed
@pavoljuhas pavoljuhas deleted the improve-replace_version-utility branch June 3, 2024 18:43
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request Jun 26, 2024
- Make `dev_tools/modules.py replace_version` update also the
  version expected in unit tests

- Skip type check in the new test-only source files

- Update `dev_tools/packaging/produce-package.sh` to use the `replace_version`
  utility when building development wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants