CI - deflake Isolated pytest Ubuntu
#6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `test_isolated_packages` may run clashing parallel builds of a local `cirq_core` wheel. Solution: Run pip-install with the `--no-clean` option so parallel builds do not delete active files.
Include standard tests as well if ever added to that file.
viathor
approved these changes
May 10, 2024
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
May 15, 2024
This partially reverts quantumlib#6593
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
May 16, 2024
This partially reverts quantumlib#6593
pavoljuhas
added a commit
that referenced
this pull request
May 16, 2024
Problem: `test_isolated_packages.py` is still flaky and can fail on parallel builds of a local `cirq_core` wheel. Solution: Use per-worker copy of the cirq-core sources so that parallel builds do not have conflicting build files. Follow-up to #6593
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
Problem: `test_isolated_packages` may run clashing parallel builds of a local `cirq_core` wheel. Solution: Run pip-install with the `--no-clean` option so parallel builds do not delete active files. Also invoke isolated_packages_test.py with `--enable-slow-tests` in CI to include non-slow tests if ever added to that file.
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
Problem: `test_isolated_packages.py` is still flaky and can fail on parallel builds of a local `cirq_core` wheel. Solution: Use per-worker copy of the cirq-core sources so that parallel builds do not have conflicting build files. Follow-up to quantumlib#6593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
test_isolated_packagesmay run clashing parallel buildsof a local
cirq_corewheel.Solution: Run pip-install with the
--no-cleanoption so parallelbuilds do not delete active files.
Also invoke isolated_packages_test.py with
--enable-slow-testsin CIto include non-slow tests if ever added to that file.