NEP-29 - enforce minimum Python version 3.10 #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy-1.22.0 is the first version that has binary wheels for Python 3.10 and is compatible with transitive requirements from cirq-all.txt. We are a bit more tolerant than NEP 29 which suggests numpy-1.23+.
pavoljuhas
requested review from
vtomole,
cduck,
a team,
HGSilveri,
ma5x,
pschindler,
dabacon,
ColemanCollins,
nakardo,
gmauricio,
wcourtney and
verult
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6591 +/- ##
==========================================
- Coverage 97.79% 97.79% -0.01%
==========================================
Files 1124 1124
Lines 95705 95704 -1
==========================================
- Hits 93595 93594 -1
Misses 2110 2110 ☔ View full report in Codecov by Sentry. |
maffoo
approved these changes
May 9, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
- Raise exception if running with Python <= 3.9.x - Clean up checks and notes relevant for old Pythons - Bump up to numpy~=1.22 which is effectively the minimum version that works with Python 3.10. We are a bit more permissive than NEP 29 which suggests numpy-1.23+. Fixes: quantumlib#6463 Ref: https://numpy.org/neps/nep-0029-deprecation_policy.html
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that works with Python 3.10. We are a bit more permissive than
NEP 29 which suggests numpy-1.23+.
Fixes: #6463
Ref: https://numpy.org/neps/nep-0029-deprecation_policy.html