Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen the scipy condition in requirements.txt #6549

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Loosen the scipy condition in requirements.txt #6549

merged 2 commits into from
Apr 4, 2024

Conversation

BichengYing
Copy link
Collaborator

@BichengYing BichengYing commented Apr 4, 2024 •
edited
Loading

In order to avoid the conflict of dependency with pyle

  SolverProblemError

  Because pyle depends on cirq-core (1.4.0.dev20240404120310) which depends on scipy (>=1.12.0,<1.13.0), scipy is required.
  So, because pyle depends on scipy (~1.9.2), version solving failed.

Previous context for scipy ~=1.12 see #6545

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (bc3f9ff) to head (ef56a24).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6549   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files        1124     1124           
  Lines       95468    95468           
=======================================
  Hits        93359    93359           
  Misses       2109     2109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BichengYing BichengYing marked this pull request as ready for review April 4, 2024 19:01
@BichengYing BichengYing requested review from vtomole, cduck and a team as code owners April 4, 2024 19:01
@NoureldinYosri
Copy link
Collaborator

related to #6543

@pavoljuhas pavoljuhas changed the title Loose the scipy condition in requirements.txt Loosen the scipy condition in requirements.txt Apr 4, 2024
@pavoljuhas pavoljuhas merged commit 9ab6601 into quantumlib:main Apr 4, 2024
31 checks passed
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@BichengYing @jselig-rigetti
Loosen the scipy condition in requirements.txt (quantumlib#6549)
c16a244 
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BichengYing @NoureldinYosri @pavoljuhas