convert SingleQubitCliffordGate to phasedXZ during serialization #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97107 97115 +8
=======================================
+ Hits 94986 94994 +8
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Jan 18, 2024
wcourtney
reviewed
Jan 18, 2024
| @@ -175,7 +175,9 @@ def _serialize_gate_op( | |||
| out=msg.phasedxpowgate.exponent, | |||
| arg_function_language=arg_function_language, | |||
| ) | |||
| elif isinstance(gate, cirq.PhasedXZGate): | |||
| elif isinstance(gate, (cirq.PhasedXZGate, cirq.ops.SingleQubitCliffordGate)): | |||
There was a problem hiding this comment.
Should this be done explicitly, e.g. with optimize_for_target_gateset rather than implicitly during serialization? IIRC, we prefer to make transformations like this explicit to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.