fix: multi-line emphasis #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Innei
pushed a commit
to Innei/markdown-to-jsx
that referenced
this pull request
Mar 28, 2024
* fix: multi-line emphasis * feat: handle newlines in mark and strikethrough formatting as well * refactor: ensure the same skip regex is used for inlines * chore: add some comments --------- Co-authored-by: Evan Jacobs <probablyup@gmail.com> Signed-off-by: Innei <i@innei.in>
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-line bolded/italic wasn't rendering properly -- the regex didn't allow a newline. Added an option for a newline character in the bold/italic regexes.
Input
Output before fix (nothing is bolded, asterisks remain on second line)
Output after fix (both lines bold)
Fixes #449