Playground to TypeScript #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for squiggle-playground failed. 🔨 Explore the source changes: c8bb0c2 🔍 Inspect the deploy log: https://app.netlify.com/sites/squiggle-playground/deploys/621ffe57a966c80008c82a01 |
|
Great, happy to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the large pull request, there's a couple of changes happening here. Hopefully however it should be relatively clear.
Playground now uses @squiggle/components
This is both a benefit for refactoring and a couple of features, however means that the playground is currently missing some of the debug functionality that use to be present in the playground, until that is re-implemented in @squiggle/components.
Playground no longer uses rescript
The playground use to contain a large amount of rescript code that was simply there to interop with existing typescript code (Antd + @squiggle/components). I've rewritten the playground in Typescript instead, feeling this is a better way to go due to this only really being a UI package
Couple of dependency problems resolved
react-vegawas causing a couple of issues with typescript. It depended on an old version of @types/react, and I had to enforce the resolution to be the newer version to allow it to compile correctly. Furthermore, a dependency ofreact-vegafast-json-patchdid not build under parcel build (parcel-bundler/parcel#7781), so I've added --no-scope-hoist to playground's build as a temporary workaround until the parcel bug gets fixed.CI scripts
There are a collection of CI scripts in the root package.json which can be used by netlify to easily build a specific playground.
Removing lerna
lerna was turning out to be a pain and I never really used it. Yarn workspaces works just fine.
After this, I'd be pretty happy to see this be the new master.