Support associating tasks with tags, minor cleanups #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also addresses some minor TODOs.
Tags are working in FakeTracker, but not WandbTracker...
Likely why WandbTracker was crashing.
Ensures that dependencies in pyproject.toml stay sorted.
… dmcc/wandb-tags/sc-14754
drewp
suggested changes
Aug 9, 2024
drewp
reviewed
Aug 9, 2024
drewp
reviewed
Aug 9, 2024
drewp
reviewed
Aug 9, 2024
drewp
suggested changes
Aug 9, 2024
drewp
reviewed
Aug 9, 2024
|
Only now do I see I could have viewed the union of all the commits and reviewed that instead. Next time! |
- `tags` should be a set, not a list. Changes throughout. - Add `--tags` to `click_options` so it shows up in the correct group. - Cleanups and improvements suggested by @drewpca.
dmcc
commented
Aug 26, 2024
drewp
reviewed
Aug 26, 2024
We now parse CSV lists and lexicalize shell commands as Click callbacks. As a result, all recipients of Click options can avoid parsing any options from the command line and instead operate on more appropriate types.
drewp
approved these changes
Aug 27, 2024
Fixed! |
dmcc
commented
Aug 27, 2024
jaredbriskman
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: You can now use
--tags tag1,tag2when launching tasks, fixes #20. All tags in the list will be associated with all launched tasks.This PR also includes some overdue Ruff and pre-commit updates, addressing their changes. Got a little carried away -- ideally, these would probably be a separate PR.