Skip to content

Commit

Permalink
js.bzl: Stop using invalid join call
Browse files Browse the repository at this point in the history
Bazel 0.27 flipped incompatible Starlark flag:
--incompatible_string_join_requires_strings, see: [1] for
more details.

[1] bazelbuild/bazel#7802

Change-Id: I639948584a65decfbe873c214c027290d9401c56
  • Loading branch information
dpursehouse committed Jul 4, 2019
1 parent eea6eda commit 4278441
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/bzl/js.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _bower_archive(ctx):

out = ctx.execute(cmd)
if out.return_code:
fail("failed %s: %s" % (" ".join(cmd), out.stderr))
fail("failed %s: %s" % (cmd, out.stderr))

_bash(ctx, " && ".join([
"TMP=$(mktemp -d || mktemp -d -t bazel-tmp)",
Expand Down Expand Up @@ -116,7 +116,7 @@ def _bash(ctx, cmd):
cmd_list = ["bash", "-c", cmd]
out = ctx.execute(cmd_list)
if out.return_code:
fail("failed %s: %s" % (" ".join(cmd_list), out.stderr))
fail("failed %s: %s" % (cmd_list, out.stderr))

bower_archive = repository_rule(
_bower_archive,
Expand Down

0 comments on commit 4278441

Please sign in to comment.