Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

WIP: Move Nuitka build to GitHub Actions #98

Closed
wants to merge 1 commit into from

Conversation

qstokkink
Copy link
Owner

@qstokkink qstokkink commented Jul 29, 2024

Fixes #97

This is a WIP/Test PR. Stay tuned.

TODO:

  • Enable Mac builds.
  • Enable Ubuntu builds.
  • Move built executable out of build directory.
  • Locate and ship libsodium DLL.
  • Locate and ship libcrypto-1_1 DLL.
  • Locate and ship libcrypto-1_1-x64 DLL.
  • Locate and ship libssl-1_1 DLL.
  • Locate and ship libssl-1_1-x64 DLL.
  • Build ui using npm and ship the resulting dist directory.
  • Fix pony assertion errors:
  File "pony\orm\core.py", line 4027, in select
  File "pony\orm\core.py", line 4388, in _query_from_args_
AssertionError
  File "pony\orm\core.py", line 4017, in get_for_update
  File "pony\orm\core.py", line 4114, in _find_one_
  File "pony\orm\core.py", line 4171, in _find_in_db_
  File "pony\orm\sqlbuilding.py", line 191, in adapter
  File "pony\orm\sqlbuilding.py", line 191, in <genexpr>
  File "pony\orm\sqlbuilding.py", line 34, in eval
AssertionError

@qstokkink qstokkink force-pushed the add_ga_builders branch 30 times, most recently from 0ecc211 to ec6d19f Compare July 30, 2024 11:52
@qstokkink qstokkink force-pushed the add_ga_builders branch 2 times, most recently from cf87bdd to 26972fe Compare July 30, 2024 12:03
@qstokkink
Copy link
Owner Author

I assumed fixing the PonyORM errors would be a small hurdle. Upon further inspection, this is a deal breaker.

  • For PonyORM the co_code of functions is the primary mechanism to determine the SQL mappings.
  • For Nuitka the co_code of functions is the one thing that is not implemented.

Faced with this mutual exclusion, considering PonyORM is already in our code base and Nuitka is not, we should drop Nuitka.

@qstokkink qstokkink closed this Jul 30, 2024
@qstokkink qstokkink changed the title WIP: Move building to GitHub Actions WIP: Move Nuitka build to GitHub Actions Aug 1, 2024
@qstokkink qstokkink deleted the add_ga_builders branch August 8, 2024 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to move building to GitHub Actions
1 participant