Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Updated builders to use GitHub Actions #107

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

qstokkink
Copy link
Owner

@qstokkink qstokkink commented Aug 2, 2024

Fixes #97

This PR:

  • Updates the build process to run on GitHub Actions.

@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 21 times, most recently from d2029fb to 4f8ba5f Compare August 5, 2024 09:44
@qstokkink

This comment was marked as resolved.

@egbertbouman
Copy link
Collaborator

If I remember correctly, pystray will first attempt to use AppIndicator3 and if that fails it will try AyatanaAppIndicator3.
You could try installing gir1.2-appindicator3-0.1 as well.

@qstokkink

This comment was marked as resolved.

@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 5 times, most recently from 52ae3e0 to c362d47 Compare August 5, 2024 13:12
@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 8 times, most recently from 1e66224 to 6a4ff9e Compare August 7, 2024 12:47
@qstokkink

This comment was marked as resolved.

@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 2 times, most recently from de3b394 to 0de8fae Compare August 7, 2024 13:38
@qstokkink
Copy link
Owner Author

Alright, Windows also seems to work🎉 Sort of: double clicking a torrent file does not download it. I think that's a separate issue though.

@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 2 times, most recently from c0c4b4c to ccf3a1a Compare August 7, 2024 14:09
@qstokkink
Copy link
Owner Author

I'm not seeing any errors on Mac. I'll have to check on a VM or something whether everything is O.K. there.

@qstokkink qstokkink force-pushed the add_ga_builders_v3 branch 2 times, most recently from 93a17b3 to c0dce21 Compare August 7, 2024 14:29
@qstokkink
Copy link
Owner Author

validate

@qstokkink
Copy link
Owner Author

@egbertbouman I still want to switch pull_request to workflow_dispatch but other than that, I'm done. Could you give this a review?

@egbertbouman
Copy link
Collaborator

Looks good to me.

Do you still want Jenkins as a fallback? It's still needed for signing the Mac build, so we can't get rid of it entirely.

@qstokkink
Copy link
Owner Author

Thanks, I'll turn this into workflow_dispatch and get this merged.

Long term, I'd like* everything to be on GitHub Actions, including signing:

  • Windows signing should be reasonably easy with our setup by just using GitHub secrets.
  • Mac could be a two-step process. First we could hook our machine in as a "self-hosted runner" into GitHub before using a GitHub-secrets approach. I'm not sure if it is smarter to just do a one-shot port though.

I don't think you can transfer secrets between repos, so I think it would be better to wait until highlander makes its way into Tribler/Tribler.

*I believe GitHub Actions and Jenkins do mostly the same thing so I'd like to keep only one to lessen our maintenance load.

@qstokkink
Copy link
Owner Author

validate

@qstokkink qstokkink marked this pull request as ready for review August 8, 2024 08:05
@qstokkink qstokkink changed the title WIP: Updated builders to use GitHub Actions READY: Updated builders to use GitHub Actions Aug 8, 2024
@qstokkink qstokkink changed the title READY: Updated builders to use GitHub Actions Updated builders to use GitHub Actions Aug 8, 2024
@qstokkink qstokkink merged commit 804dd2c into highlander Aug 8, 2024
6 checks passed
@qstokkink qstokkink deleted the add_ga_builders_v3 branch August 8, 2024 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to move building to GitHub Actions
2 participants