Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ion and keypadlock control. #21

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Support ion and keypadlock control. #21

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f023f29
Support ion and keypadlock control.
Jul 17, 2024
650410b
Remove print log and defrost model.
Jul 17, 2024
c444a1b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 17, 2024
7f580d4
Fixed Ion dictionary format.
Jul 17, 2024
4324f84
Rollback the legacy_name to None.
Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions JciHitachi/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,11 +1822,11 @@ def __init__(self, status, default=0):
"is_numeric": True,
"legacy_name": "power_kwh",
},
"Ion": { # currently not supported
"controllable": False,
"Ion": {
"controllable": True,
"is_numeric": False,
"legacy_name": None,
"id2str": {},
"legacy_name": "ion",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't add "new" legacy names anymore. They exist only for BC reasons that I have been lazy to resolve. Let's just use its regular name Ion (and please modify the PR in JciHitachiHA accordingly).

Copy link
Owner

@qqaatw qqaatw Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding a legacy name ion to it, and we don't do that anymore because it is "legacy".

Simply set legacy_name to None and use its regular name Ion instead. You can look at the Defrost below as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks your response, i modify and push.

"id2str": {0: "disabled", 1: "enabled"},
},
"HumiditySetting": {
"controllable": True,
Expand All @@ -1845,8 +1845,11 @@ def __init__(self, status, default=0):
"KeypadLock": {
"controllable": True,
"is_numeric": False,
"legacy_name": None,
"id2str": {},
"legacy_name": "keypad_lock",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"id2str": {
0: "disabled",
1: "enabled",
},
},
"DisplayBrightness": {
"controllable": True,
Expand Down