Base.convert(::Type{Operator}, ::Operator) #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 93.33% 93.34%
=======================================
Files 24 24
Lines 2881 2885 +4
=======================================
+ Hits 2689 2693 +4
Misses 192 192
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The breakage in QuantumOptics (in the steady state submodule) is not spurious, it is actually there, and it is actually caused by this change... But I have no idea why... Suggestions would be welcomed. |
This is expected by the convert api, e.g.
```
julia> a = [1]
1-element Vector{Int64}:
1
julia> b = convert(Vector{Int},a)
1-element Vector{Int64}:
1
julia> a[1] = 2; b
1-element Vector{Int64}:
2
```
|
The breakage was because this new I am merging this as it is strictly a bugfix not affecting the rest of the system and follows Julia base conventions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106