feat: enhance Azure DevOps integration with improved error handling a…

[hussam789]

User description

…nd PR commands

---

PR Type

Enhancement, Bug fix

---

Description

• Enhanced Azure DevOps integration with new PR commands and error handling.

• Added get_line_link method for generating file line links.

• Improved webhook handling with better logging and structured responses.

• Updated configuration to include Azure DevOps PR commands.

---

Changes walkthrough 📝

	Relevant files
Enhancement	azuredevops_provider.py Enhance PR handling and add line link generation                  pr_agent/git_providers/azuredevops_provider.py Added set_pr method to set PR URL and parse details. Introduced get_line_link method for generating file line links. Changed logging level for PR ID retrieval errors. +5/-1      azuredevops_server_webhook.py Refactor Azure DevOps webhook handling and logging              pr_agent/servers/azuredevops_server_webhook.py Refactored webhook handling for Azure DevOps events. Improved error logging with contextual information. Added structured JSON responses for webhook triggers. Introduced handle_request_azure for streamlined request processing. +27/-18
Bug fix	pr_description.py Adjust error handling for line link generation                      pr_agent/tools/pr_description.py Modified error handling for line link generation. Prevented unnecessary warnings for missing line links. +3/-2
Configuration changes	configuration.toml Add Azure DevOps server configuration and commands              pr_agent/settings/configuration.toml Added Azure DevOps server configuration section. Included default PR commands for Azure DevOps. +8/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns Authentication validation: The webhook endpoint uses basic HTTP authentication with username/password. While HTTPS is required, storing credentials in configuration files could pose a security risk if the configuration is not properly secured. Consider using more secure authentication methods like OAuth tokens.

⚡ Recommended focus areas for review Error Handling The new handle_request_comment function is called without await despite being an async function, which could lead to unhandled coroutines and unexpected behavior handle_request_comment(pr_url, action, log_context) Dead Code The commented out code and empty link assignment is redundant since link is already initialized as empty string above # get_logger().warning(f"Error getting line link for '{filename}'") link = "" # continue

[qodo-merge-pro-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Add missing async keyword Suggestion Impact: The commit added the async keyword to handle_request_comment function and updated the calling code to use await code diff: -def handle_request_comment( url: str, body: str, log_context: dict +async def handle_request_comment( url: str, body: str, log_context: dict ): log_context["action"] = body log_context["api_url"] = url @@ -121,7 +121,7 @@ for action in actions: try: - handle_request_comment(pr_url, action, log_context) + await handle_request_comment(pr_url, action, log_context) The handle_request_comment function is missing the async keyword, but it uses await inside. This will cause a runtime error. Add the async keyword to make it a proper asynchronous function. pr_agent/servers/azuredevops_server_webhook.py [36-39] -def handle_request_comment( url: str, body: str, log_context: dict +async def handle_request_comment( url: str, body: str, log_context: dict ): log_context["action"] = body log_context["api_url"] = url [Suggestion has been applied] Suggestion importance[1-10]: 10 __ Why: The function uses 'await' internally but lacks the 'async' keyword, which would cause a runtime error. This is a critical bug that would prevent the webhook handler from functioning properly.	High
General	Add error handling for background task The handle_request_azure function is called as a background task but its exceptions are not properly handled. Add error handling in the background task execution to prevent silent failures. pr_agent/servers/azuredevops_server_webhook.py [141] -background_tasks.add_task(handle_request_azure, data, log_context) +async def wrapped_handle_request(): + try: + await handle_request_azure(data, log_context) + except Exception as e: + get_logger().exception("Background task failed", error=str(e)) +background_tasks.add_task(wrapped_handle_request) Apply this suggestion Suggestion importance[1-10]: 8 __ Why: Adding proper error handling for background tasks is important for system reliability and debugging. Without it, failures in background tasks would be silently ignored, making issues harder to detect and fix.	Medium
Learned best practice	Add input validation and error handling when processing potentially invalid or missing data Add null safety checks when accessing the PR URL and parsing details in the set_pr method. The current implementation assumes all required attributes will be available, which could lead to runtime errors if any are missing. pr_agent/git_providers/azuredevops_provider.py [185-188] def set_pr(self, pr_url: str): + if not pr_url: + raise ValueError("PR URL cannot be empty") self.pr_url = pr_url - self.workspace_slug, self.repo_slug, self.pr_num = self._parse_pr_url(pr_url) - self.pr = self._get_pr() + try: + self.workspace_slug, self.repo_slug, self.pr_num = self._parse_pr_url(pr_url) + self.pr = self._get_pr() + except Exception as e: + raise ValueError(f"Failed to parse PR URL: {e}") Apply this suggestion Suggestion importance[1-10]: 6	Low
Update

• Author self-review: I have reviewed the PR code suggestions, and addressed the relevant ones.