Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear weak_mods before AS/TD. #9941

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Clear weak_mods before AS/TD. #9941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5eebcc
Fixes #4072, #6214. Revision of #156 to clear before AS/TD.
IsaacElenbaas Aug 5, 2020
6d5b7f1
Merge branch 'master' into early-clear-wm
tzarc Feb 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tmk_core/common/action.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ void action_exec(keyevent_t event) {
#endif
}

if (event.pressed) {
// clear the potential weak mods left by previously pressed keys
clear_weak_mods();
}

#ifdef SWAP_HANDS_ENABLE
if (!IS_NOEVENT(event)) {
process_hand_swap(&event);
Expand Down Expand Up @@ -237,11 +242,6 @@ void process_action(keyrecord_t *record, action_t action) {
uint8_t tap_count = record->tap.count;
#endif

if (event.pressed) {
// clear the potential weak mods left by previously pressed keys
clear_weak_mods();
}

#ifndef NO_ACTION_ONESHOT
bool do_release_oneshot = false;
// notice we only clear the one shot layer if the pressed key is not a modifier.
Expand Down