Fix incorrect layout for GHS.rar #9597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
approved these changes
Jul 3, 2020
fauxpark
requested changes
Jul 3, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
Thanks! I'll get working on the changes right away. |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Jul 6, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (154 commits) Fix typo in freebsd_install.sh (qmk#9655) [Keymap] Add Alice rev2 to my userspace (qmk#9600) [Keyboard] RART67 : add support via (qmk#9589) [Keyboard] XD87 Caps Lock LED refactor (qmk#9585) [Keyboard] Updated VIA Support for DP60 (qmk#9508) fixed link to Eclipse instructions (qmk#9647) format code according to conventions [skip ci] add DIP_SWITCH_MATRIX_GRID support (qmk#8772) add SPLIT_HAND_MATRIX_GRID support (qmk#8685) [Keyboard] Gowla Macro Board (qmk#9643) Fix “G” in Neo2 keymap (qmk#9645) Rotr - Updated README and default keymap (qmk#9598) Add missing dependency for Void Linux to util/linux-install.sh (qmk#9637) Backlight docs wordsmithing (qmk#9631) Fix incorrect layout for GHS.rar (qmk#9597) Add movement hook to ps2_mouse (qmk#8805) Make sendstring respect `TAP_CODE_DELAY` (qmk#9623) [Keymap] Adding a Custom Keymap for Matrix Noah (qmk#9581) Fix sharing of mouse button state from mousekeys to ps2_mouse (qmk#9124) Add xjtian keymap for Planck (qmk#9502) ...
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the layout for GHS.rar as pointed out in this comment.
Types of Changes
Issues Fixed or Closed by This PR
Previously, it would compile the firmware even if the layout was missing RShift. I've added the RShift to the layouts and removed the commas at the ends of the
LAYOUT_*macros.Checklist