Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use keymap.json files in layouts/ #9553

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

firetech
Copy link
Contributor

Add ability to build keymaps from keymap.json in the layouts directory as well.

Description

Currently, keymaps can be built from JSON format when placed in keyboards/.../keymaps/.../, but only keymap.c is supported when placed in layouts/. This small change adds support for keymap.json files placed in the layouts directory.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from a team and jackhumbert July 5, 2020 02:44
@Erovia Erovia requested review from skullydazed and a team July 6, 2020 19:01
@skullydazed skullydazed merged commit 5eb4675 into qmk:master Jul 7, 2020
@skullydazed
Copy link
Member

Thanks!

@firetech firetech deleted the build_layouts_from_json branch July 7, 2020 14:30
@firetech firetech mentioned this pull request Jun 23, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants