Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HD44780 References, Part 1 #9052

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented May 9, 2020

Description

Removes references to the HD44780 LCD Display from config.h and rules.mk files.

There aren't any keyboards in the tree that use this feature, so its configuration and rules settings are basically bloat.

This doesn't remove the feature from QMK.

Part 1 of a series. Covers keyboards starting with 0-9 and A-B.

TODO

  • remove the references from the template files
    • maybe will go in this PR, maybe in a separate one specifically for the templates.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 19, 2020 10:34
@stale
Copy link

stale bot commented Jul 3, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@Erovia
Copy link
Member

Erovia commented Jul 3, 2020

Can you resolve the conflict and put the pr into "normal" (or whatever it's called) mode?

@stale stale bot removed the awaiting changes label Jul 9, 2020
@noroadsleft noroadsleft marked this pull request as ready for review July 9, 2020 07:06
@tzarc
Copy link
Member

tzarc commented Jul 22, 2020

Anything in particular holding this up?
Should this be going to a different branch given that it's modifying keyboards?

@noroadsleft
Copy link
Member Author

I wasn't inclined to merge my own PR.

This shouldn't be modifying anything that's actually being used. None of the keyboards being modified enable the HD44780 feature.

@tzarc tzarc merged commit aaf5815 into qmk:master Jul 26, 2020
@noroadsleft noroadsleft deleted the remove-hd44780-1 branch July 28, 2020 02:14
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* remove HD44780_ENABLE rules: 0-9, A-B

* remove HD44780_ENABLE config: 0-9, A-B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants