-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oddball keyboard - trackball improvements #8657
Conversation
Thank you for your contribution! |
Bump; this is still good to go. Let me know if there is anything I can do to help with the review. |
@atulloh is this just pending a conversion over to the |
Yep, I just need to make the |
Hi, looking at the PR Lint keyboards action, which failed, it seems like it was some issue determining file changes rather than linting? Perhaps it was caused by a big merge bringing my branch up to date? Or perhaps I just have lint errors 😛 |
From what I've been able to determine seeing that test fail on other PRs, is that it fails if a file is deleted or moved (not sure about renames). |
Any tips on resolving them? Maybe it was my massive merge commit; I'll try a rebase instead. |
646eb7e
to
2afebdf
Compare
Looks like it is fixed in an updated version of the |
Mostly, "not your problem". As long as it compiles properly, and according to Travis CI, it does. |
I've got a bunch of changes that have superseded this PR, so I'll kill this one off and open another. |
Description
Improved ADNS9800 trackball code on the Oddball keyboard:
Types of Changes
Issues Fixed or Closed by This PR
None
Checklist