Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oddball keyboard - trackball improvements #8657

Closed
wants to merge 24 commits into from

Conversation

atulloh
Copy link
Contributor

@atulloh atulloh commented Apr 2, 2020

Description

Improved ADNS9800 trackball code on the Oddball keyboard:

  • added scrolling
  • added click and drag
  • added dynamic CPI and saving CPI setting to EEPROM
  • separated keyboard/user code from sensor code
  • fixed occasionally erratic motion tracking
  • updated ADNS firmware

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 5, 2020 08:04
@stale
Copy link

stale bot commented May 20, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@atulloh
Copy link
Contributor Author

atulloh commented May 20, 2020

Bump; this is still good to go. Let me know if there is anything I can do to help with the review.

@tzarc
Copy link
Member

tzarc commented Jul 25, 2020

@atulloh is this just pending a conversion over to the spi_master driver mentioned by fauxpark? Were there any further modifications you were going to do?

@atulloh
Copy link
Contributor Author

atulloh commented Jul 26, 2020

@atulloh is this just pending a conversion over to the spi_master driver mentioned by fauxpark? Were there any further modifications you were going to do?

Yep, I just need to make the spi changes; nothing further.

@atulloh
Copy link
Contributor Author

atulloh commented Aug 26, 2020

Hi, looking at the PR Lint keyboards action, which failed, it seems like it was some issue determining file changes rather than linting? Perhaps it was caused by a big merge bringing my branch up to date? Or perhaps I just have lint errors 😛

@noroadsleft
Copy link
Member

Hi, looking at the PR Lint keyboards action, which failed, it seems like it was some issue determining file changes rather than linting? Perhaps it was caused by a big merge bringing my branch up to date? Or perhaps I just have lint errors stuck_out_tongue

From what I've been able to determine seeing that test fail on other PRs, is that it fails if a file is deleted or moved (not sure about renames).

@atulloh
Copy link
Contributor Author

atulloh commented Aug 27, 2020

Hi, looking at the PR Lint keyboards action, which failed, it seems like it was some issue determining file changes rather than linting? Perhaps it was caused by a big merge bringing my branch up to date? Or perhaps I just have lint errors stuck_out_tongue

From what I've been able to determine seeing that test fail on other PRs, is that it fails if a file is deleted or moved (not sure about renames).

Any tips on resolving them? Maybe it was my massive merge commit; I'll try a rebase instead.

@atulloh atulloh force-pushed the development/oddball branch from 646eb7e to 2afebdf Compare August 27, 2020 00:35
@atulloh
Copy link
Contributor Author

atulloh commented Aug 27, 2020

Looks like it is fixed in an updated version of the trilom/file-changes-action: trilom/file-changes-action#104

@drashna
Copy link
Member

drashna commented Aug 28, 2020

Any tips on resolving them? Maybe it was my massive merge commit; I'll try a rebase instead.

Mostly, "not your problem". As long as it compiles properly, and according to Travis CI, it does.

@atulloh
Copy link
Contributor Author

atulloh commented Sep 20, 2020

I've got a bunch of changes that have superseded this PR, so I'll kill this one off and open another.

@atulloh atulloh closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants