[New keyboard]silverbullet44 #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once
Maxr1998
suggested changes
Jan 21, 2020
Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com>
Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com>
Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com>
|
@Maxr1998 |
drashna
requested changes
Jan 22, 2020
fauxpark
requested changes
Jan 22, 2020
Maxr1998
approved these changes
Jan 22, 2020
drashna
reviewed
Jan 22, 2020
Maxr1998
approved these changes
Jan 23, 2020
|
How about a review? |
fauxpark
requested changes
Feb 5, 2020
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
|
@fauxpark |
|
...should I close it? |
|
No, just have some more patience please, someone will probably review it soon 😇 |
drashna
approved these changes
Feb 21, 2020
fauxpark
approved these changes
Feb 21, 2020
|
Thanks! |
nesth
pushed a commit
to nesth/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* upstream/master: (330 commits) Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) Use pathlib everywhere we can (qmk#7872) ...
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Feb 23, 2020
* make silverbullet44 * comment edit * venderID * Fix parentheses in macros, and in general clean up quantum.h (qmk#5021) * Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once * alt+tab * copy from master:silverbullet44 * adjust for pull request * clang-format * create info.json * Delete new_project.sh * Update keyboards/silverbullet44/keymaps/default/config.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.c Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Apply suggestions from Maxr1998 * format default keymap * Apply suggestions from Maxr1998 (qmk#2) * Apply suggestions from fauxpark * fix readme.md * Apply suggestion from Maxr1998. (custom_keycode to MO(_ADJUST)) * I became a tricky! Hahaha!! * Add original keymap made by FKML * deleated at config.h * Changed Copyright * Delete // Defines the keycodes used by our macros in process_record_user //enum custom_keycodes { // QMKBEST = SAFE_RANGE, // QMKURL //}; * Delete bool alt_pressed = false; * Delete ADJUST * Delete / * Delete void matrix_scan_user(void) { } void led_set_user(uint8_t usb_led) { } * Change Copyright's year. * Delete adjust * Delete adjust * Delete adjust * 列挙型に変更 * Enclose keymap with ```. * Delete #define _______ KC_TRNS #define XXXXXXX KC_NO * Fix indentation. * Delete some rows. * Aligned columns of ''readme.md''. * I got god's keymap...hahaha:) * Update keyboards/silverbullet44/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/silverbullet44/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> Co-authored-by: Konstantin Đorđević <vomindoraan@gmail.com> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
nesth
pushed a commit
to nesth/qmk_firmware
that referenced
this pull request
Feb 27, 2020
* 'master' of https://github.com/nesth/qmk_firmware: (331 commits) helix like crkbd Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Mar 5, 2020
* make silverbullet44 * comment edit * venderID * Fix parentheses in macros, and in general clean up quantum.h (qmk#5021) * Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once * alt+tab * copy from master:silverbullet44 * adjust for pull request * clang-format * create info.json * Delete new_project.sh * Update keyboards/silverbullet44/keymaps/default/config.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.c Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Apply suggestions from Maxr1998 * format default keymap * Apply suggestions from Maxr1998 (qmk#2) * Apply suggestions from fauxpark * fix readme.md * Apply suggestion from Maxr1998. (custom_keycode to MO(_ADJUST)) * I became a tricky! Hahaha!! * Add original keymap made by FKML * deleated at config.h * Changed Copyright * Delete // Defines the keycodes used by our macros in process_record_user //enum custom_keycodes { // QMKBEST = SAFE_RANGE, // QMKURL //}; * Delete bool alt_pressed = false; * Delete ADJUST * Delete / * Delete void matrix_scan_user(void) { } void led_set_user(uint8_t usb_led) { } * Change Copyright's year. * Delete adjust * Delete adjust * Delete adjust * 列挙型に変更 * Enclose keymap with ```. * Delete #define _______ KC_TRNS #define XXXXXXX KC_NO * Fix indentation. * Delete some rows. * Aligned columns of ''readme.md''. * I got god's keymap...hahaha:) * Update keyboards/silverbullet44/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/silverbullet44/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> Co-authored-by: Konstantin Đorđević <vomindoraan@gmail.com> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* make silverbullet44 * comment edit * venderID * Fix parentheses in macros, and in general clean up quantum.h (qmk#5021) * Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once * alt+tab * copy from master:silverbullet44 * adjust for pull request * clang-format * create info.json * Delete new_project.sh * Update keyboards/silverbullet44/keymaps/default/config.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.c Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Apply suggestions from Maxr1998 * format default keymap * Apply suggestions from Maxr1998 (qmk#2) * Apply suggestions from fauxpark * fix readme.md * Apply suggestion from Maxr1998. (custom_keycode to MO(_ADJUST)) * I became a tricky! Hahaha!! * Add original keymap made by FKML * deleated at config.h * Changed Copyright * Delete // Defines the keycodes used by our macros in process_record_user //enum custom_keycodes { // QMKBEST = SAFE_RANGE, // QMKURL //}; * Delete bool alt_pressed = false; * Delete ADJUST * Delete / * Delete void matrix_scan_user(void) { } void led_set_user(uint8_t usb_led) { } * Change Copyright's year. * Delete adjust * Delete adjust * Delete adjust * 列挙型に変更 * Enclose keymap with ```. * Delete #define _______ KC_TRNS #define XXXXXXX KC_NO * Fix indentation. * Delete some rows. * Aligned columns of ''readme.md''. * I got god's keymap...hahaha:) * Update keyboards/silverbullet44/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/silverbullet44/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> Co-authored-by: Konstantin Đorđević <vomindoraan@gmail.com> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* make silverbullet44 * comment edit * venderID * Fix parentheses in macros, and in general clean up quantum.h (qmk#5021) * Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once * alt+tab * copy from master:silverbullet44 * adjust for pull request * clang-format * create info.json * Delete new_project.sh * Update keyboards/silverbullet44/keymaps/default/config.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.c Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Apply suggestions from Maxr1998 * format default keymap * Apply suggestions from Maxr1998 (qmk#2) * Apply suggestions from fauxpark * fix readme.md * Apply suggestion from Maxr1998. (custom_keycode to MO(_ADJUST)) * I became a tricky! Hahaha!! * Add original keymap made by FKML * deleated at config.h * Changed Copyright * Delete // Defines the keycodes used by our macros in process_record_user //enum custom_keycodes { // QMKBEST = SAFE_RANGE, // QMKURL //}; * Delete bool alt_pressed = false; * Delete ADJUST * Delete / * Delete void matrix_scan_user(void) { } void led_set_user(uint8_t usb_led) { } * Change Copyright's year. * Delete adjust * Delete adjust * Delete adjust * 列挙型に変更 * Enclose keymap with ```. * Delete #define _______ KC_TRNS #define XXXXXXX KC_NO * Fix indentation. * Delete some rows. * Aligned columns of ''readme.md''. * I got god's keymap...hahaha:) * Update keyboards/silverbullet44/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/silverbullet44/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> Co-authored-by: Konstantin Đorđević <vomindoraan@gmail.com> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* make silverbullet44 * comment edit * venderID * Fix parentheses in macros, and in general clean up quantum.h (qmk#5021) * Fix up GPIO macros * Fix up send string macros `string` arguments must not be parenthesized * Fix up miscellaneous macros * Make indentation uniform (4 spaces) * Make #ifdef vs #if defined usage consistent * Reorder standard includes * Revert indentation changes as per review comments * Revert #if defined(__AVR__) → #ifdef __AVR__ change * Change 2 space indent to 4 spaces on a couple of lines * Replace include guard with #pragma once * alt+tab * copy from master:silverbullet44 * adjust for pull request * clang-format * create info.json * Delete new_project.sh * Update keyboards/silverbullet44/keymaps/default/config.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.c Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Update keyboards/silverbullet44/silverbullet44.h Co-Authored-By: Max Rumpf <max.rumpf1998@gmail.com> * Apply suggestions from Maxr1998 * format default keymap * Apply suggestions from Maxr1998 (qmk#2) * Apply suggestions from fauxpark * fix readme.md * Apply suggestion from Maxr1998. (custom_keycode to MO(_ADJUST)) * I became a tricky! Hahaha!! * Add original keymap made by FKML * deleated at config.h * Changed Copyright * Delete // Defines the keycodes used by our macros in process_record_user //enum custom_keycodes { // QMKBEST = SAFE_RANGE, // QMKURL //}; * Delete bool alt_pressed = false; * Delete ADJUST * Delete / * Delete void matrix_scan_user(void) { } void led_set_user(uint8_t usb_led) { } * Change Copyright's year. * Delete adjust * Delete adjust * Delete adjust * 列挙型に変更 * Enclose keymap with ```. * Delete #define _______ KC_TRNS #define XXXXXXX KC_NO * Fix indentation. * Delete some rows. * Aligned columns of ''readme.md''. * I got god's keymap...hahaha:) * Update keyboards/silverbullet44/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/silverbullet44/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> Co-authored-by: Konstantin Đorđević <vomindoraan@gmail.com> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Keyboard SilverBullet44
Description
A hard keyboard with a hard keystroke that uses aluminum PCB for the top plate.
Upgradable from sandwich mount to top mount by using optional parts.
Types of Changes
Issues Fixed or Closed by This PR
Checklist