Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert zinc to use split_common #7111

Closed
wants to merge 3 commits into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 22, 2019

Description

Left some config in which ideally should be removed, like changing the default tapping term. But the target is to maintain backwards compatibility with existing keymaps.

Tagging @monksoffunk as maintainer.

TODO:

  • Swap to RGBLED_SPLIT and confirm led behaviour

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Oct 22, 2019
@drashna drashna requested a review from a team October 22, 2019 03:09
@monksoffunk
Copy link
Contributor

Thanks for your contributions!
I've already prepared the split_common version.
https://github.com/monksoffunk/qmk_firmware/tree/zinc_splitcommon/keyboards/zinc

Also, I've done the RGB Matrix version based on the current zinc codes, cause the RGB Matrix is not fully compatible with split_common.
https://github.com/monksoffunk/qmk_firmware/tree/zinc_RGB_matrix/keyboards/zinc

So I can't decide which version should I PR...

@drashna
Copy link
Member

drashna commented Oct 22, 2019

@monksoffunk Split common needs something like #5998 to work properly with some of the rgb matrix effects.

@zvecr
Copy link
Member Author

zvecr commented Oct 22, 2019

A RGBLED_SPLIT version can be deployed right now, where a fully working RGB matrix version that isnt using the crkbd method of building 2 different firmwares will be blocked on the PR Drashna mentions.

Given some recent hardware issues, my preference would be to migrate to split_common where possible.

And as a final side note, your "split_common" version would have to go through the breaking changes process, as it changes user keymaps.

@monksoffunk
Copy link
Contributor

@zvecr @drashna
Thanks to you, I opened #7114.

@zvecr zvecr mentioned this pull request Oct 22, 2019
13 tasks
@zvecr zvecr closed this Oct 22, 2019
@zvecr zvecr deleted the feature/zinc_split_common branch April 28, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants