Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve keyboard_aliases when processing keyboard make targets #24834

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 20, 2025

Description

The aim is to minimise disruption to end users while we continue the deprecation process of DEFAULT_FOLDER.

Implementation is somewhat less than ideal, but hopefully its only temporary while DEFAULT_FOLDER handling still exists.

Enabled keyboard_aliases.hjson values to be used, for example

make 2_milk:default

While still allowing keyboards with DEFAULT_FOLDER to compile as before

make yosino58:default

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core python cli qmk cli command labels Jan 20, 2025
@zvecr zvecr force-pushed the deprecate_default_folder1 branch from 0eb613f to 79d4cba Compare January 20, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant