Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Led Double Buffer #23625

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[Core] Led Double Buffer #23625

wants to merge 7 commits into from
+148 −14

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Apr 27, 2024 •
edited
Loading

Description

Takes over from #22119

Adds double buffer functionality for LED matrix and RGB Matrix since RGB Matrix and LED Matrix both use the underlying drivers to set the values.

EDIT: Adds double buffer functionality now for ALL lighting systems.

This feature is disabled by DEFAULT due to the ever present hardware of microcontrollers with very limited RAM.
It should only be enabled by testing if there is enough RAM.

(tested on Pachi RGB Rev2, with VIA keymap, your numbers may vary)
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds double buffering to all drivers that are supported in RGB/LED Matrix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Apr 27, 2024
@Xelus22 Xelus22 mentioned this pull request Apr 27, 2024
Closed
14 tasks
@drashna drashna requested a review from fauxpark April 29, 2024 22:38
drashna
drashna approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the original, and seemed to work fine for the enabled drivers. But it's a bit more of a technical area, so I'm not as sure about it.

@drashna drashna requested a review from a team April 29, 2024 22:41
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 14, 2024
@drashna drashna added awaiting review breaking_change_2024q3 and removed stale Issues or pull requests that have become inactive without resolution. labels Jun 20, 2024
@tzarc tzarc added develop-fast-track Intended to be merged early in the next develop cycle. and removed breaking_change_2024q3 labels Aug 12, 2024
@Xelus22 Xelus22 force-pushed the core_led_double_buffer branch from 0645dca to f30832c Compare November 28, 2024 07:18
@github-actions github-actions bot added documentation dd Data Driven Changes labels Nov 28, 2024
@Xelus22 Xelus22 force-pushed the core_led_double_buffer branch from d878171 to f4cd06a Compare December 1, 2024 10:39
zvecr
zvecr requested changes Dec 1, 2024
View reviewed changes
quantum/led_matrix/led_matrix.c Outdated Show resolved Hide resolved
quantum/rgb_matrix/rgb_matrix.c Outdated Show resolved Hide resolved
quantum/rgblight/rgblight.c Outdated Show resolved Hide resolved
quantum/rgblight/rgblight.c Outdated Show resolved Hide resolved
@Xelus22
Copy link
Contributor Author

Xelus22 commented Dec 1, 2024

image
Not sure why but qmk format-c gives a different lint to the github actions linter

@zvecr
Copy link
Member

zvecr commented Dec 1, 2024

Different version of clang-format to the one used in CI.

dexter93
dexter93 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@dexter93 dexter93 dexter93 approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
awaiting review core dd Data Driven Changes develop-fast-track Intended to be merged early in the next develop cycle. documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xelus22 @zvecr @dexter93 @drashna @tzarc