Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaining OSL and MO #23065

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

DavidSannier
Copy link
Contributor

@DavidSannier DavidSannier commented Feb 12, 2024

Description

Make it possible to chain One Shot Layer and Momentary Layer or another One Shot Layer
When a one shot layer is active and a key other than a modifier is pressed, the one shot layer is cleared
and the release of this key is reported just before returning fromprocess_action
This release is surrounded by layer_on(get_oneshot_layer()) and layer_off(get_oneshot_layer())
It works well for regular keys, but for layer switching, it turns off the requested layer prematurely
Resetting do_release_oneshot in this case will avoid this behavior

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 12, 2024
@github-actions github-actions bot added keyboard keymap documentation python cli qmk cli command via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels Apr 9, 2024
@DavidSannier DavidSannier force-pushed the chaining_osl_and_mo branch from e2b519f to bd4256a Compare April 9, 2024 12:59
@github-actions github-actions bot removed keyboard keymap documentation python cli qmk cli command via Adds via keymap and/or updates keyboard for via support CI dd Data Driven Changes labels Apr 9, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 13, 2024
@DavidSannier DavidSannier requested a review from drashna June 15, 2024 14:51
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 16, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 10, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Nov 10, 2024
@DavidSannier
Copy link
Contributor Author

DavidSannier commented Dec 9, 2024

@tzarc, this PR was flagged 'breaking_change_2024q3', 'breaking_change_2024q4', but then 'stale' before getting merged.
Do I need to open another one ?

@tzarc tzarc reopened this Dec 9, 2024
@tzarc tzarc added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Dec 9, 2024
@tzarc
Copy link
Member

tzarc commented Dec 9, 2024

I honestly don't know why this wasn't looked at -- usually we ignore PRs which have merge conflicts or other issues because it's up to the PR submitter to keep things updated... but that's not the case here.

I'll flag it with the rest of the team for review.

@drashna drashna added the breaking_change_2025q1 Targeting breaking changes Q1 2025 label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review breaking_change_2025q1 Targeting breaking changes Q1 2025 core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants