-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chaining OSL and MO #23065
base: develop
Are you sure you want to change the base?
Chaining OSL and MO #23065
Conversation
e2b519f
to
bd4256a
Compare
776a72c
to
17097dd
Compare
17097dd
to
b7a1600
Compare
68e4f45
to
1fcabb7
Compare
1fcabb7
to
e9b5b12
Compare
Thank you for your contribution! |
Thank you for your contribution! |
Thank you for your contribution! |
@tzarc, this PR was flagged 'breaking_change_2024q3', 'breaking_change_2024q4', but then 'stale' before getting merged. |
I honestly don't know why this wasn't looked at -- usually we ignore PRs which have merge conflicts or other issues because it's up to the PR submitter to keep things updated... but that's not the case here. I'll flag it with the rest of the team for review. |
Description
Make it possible to chain One Shot Layer and Momentary Layer or another One Shot Layer
When a one shot layer is active and a key other than a modifier is pressed, the one shot layer is cleared
and the release of this key is reported just before returning from
process_action
This release is surrounded by
layer_on(get_oneshot_layer())
andlayer_off(get_oneshot_layer())
It works well for regular keys, but for layer switching, it turns off the requested layer prematurely
Resetting
do_release_oneshot
in this case will avoid this behaviorTypes of Changes
Issues Fixed or Closed by This PR
Checklist