Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keychron boards Part 2 #21423

Closed
wants to merge 40 commits into from
Closed

Update Keychron boards Part 2 #21423

wants to merge 40 commits into from

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Jul 1, 2023 •
edited
Loading

Description

This is Part 2 of a 5-part series of PRs to updating the entire Keychron lineup to current QMK standards. Since doing 1 PR to update 25 keyboards is unmanageable, doing them in batches would help make it tolerable. (What is changed can be shown in Part 1 below.)

Keyboard-specific

  • Q6
    • Since the non-encoder variants use 2 extra pins (A2 and C14) for the columns vs. not having them in the encoder variants, the matrix_pins must be specified in each variant's info.json seperately.

Part 1 involves updating the following KC boards:

  • Q5
  • Q6
  • Q7
  • Q8
  • Q9

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 3, 2023 08:04
adophoxia added 9 commits July 8, 2023 16:29
@adophoxia
Add back comment block for RGB Matrix effects
1fcc94c
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
a864898 
…-update-part-2
@adophoxia
Merge branch 'kc-update-part-2' of https://github.com/adophoxia/qmk_f…
b300879 
…irmware into kc-update-part-2
@adophoxia
Update readme.mds
403c4e5
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
b608578 
…-update-part-2
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
2ae8608 
…-update-part-2
@adophoxia
Merge branch 'kc-update-part-2' of https://github.com/adophoxia/qmk_f…
ef814e1 
…irmware into kc-update-part-2
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
23f0b4a 
…-update-part-2
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
a9be0dd 
…-update-part-2
@adophoxia adophoxia requested a review from fauxpark August 3, 2023 03:34
@drashna drashna self-requested a review August 30, 2023 05:41
@linouxis9
Copy link

Looking for the Q6 to be merged, thanks a lot for your refactoring!!

@adophoxia
Copy link
Contributor Author

Q6 is already in master.

drashna
drashna requested changes Oct 12, 2023
View reviewed changes
keyboards/keychron/q5/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q5/info.json Outdated Show resolved Hide resolved
keyboards/keychron/q6/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q8/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q9/config.h Outdated Show resolved Hide resolved
adophoxia and others added 7 commits October 12, 2023 17:51
@adophoxia @drashna
Update keyboards/keychron/q5/config.h
cd084cd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia @drashna
Update keyboards/keychron/q6/config.h
ab70d14 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia @drashna
Update keyboards/keychron/q8/config.h
1f38bda 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia @drashna
Update keyboards/keychron/q9/config.h
e786d59 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into kc…
cce0fd3 
…-update-part-2
@adophoxia
Remove dupe PID and Device Version in q5/info.json
498ca20
@adophoxia
Remove some features
8c69242
@adophoxia adophoxia requested a review from drashna October 13, 2023 01:06
@drashna drashna requested a review from a team November 11, 2023 18:50
@adophoxia adophoxia mentioned this pull request Nov 30, 2023
Merged
14 tasks
@adophoxia
Copy link
Contributor Author

Closing this PR for the sake of making each board have its own PR for sanity.

@adophoxia adophoxia closed this Nov 30, 2023
This was referenced Nov 30, 2023
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adophoxia @linouxis9 @drashna @fauxpark