Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keychron S1 #19378

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Add Keychron S1 #19378

merged 4 commits into from
Dec 20, 2022

Conversation

KeychronMacro
Copy link
Contributor

@KeychronMacro KeychronMacro commented Dec 19, 2022

Added new keyboard S1.
Thanks!

Description

Added ANSI version with RGB backlight and White backlight.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 19, 2022
@tzarc tzarc merged commit 8560280 into qmk:master Dec 20, 2022
hypanim added a commit to hypanim/qmk_firmware that referenced this pull request Dec 20, 2022
@KeychronMacro KeychronMacro deleted the keychron-s1 branch December 27, 2022 01:19
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants