Bandominedoni encoder fix #18229
Merged
Bandominedoni encoder fix #18229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Asymmetric encoders, encoder tests. (qmk#16068) is applied.)
drashna
requested changes
Aug 31, 2022
keyboards/bandominedoni/config.h
Outdated
Comment on lines
258
to
260
| # define ENCODERS 1 | ||
| # define ENCODERS_CW_KEY { {6, 5} } | ||
| # define ENCODERS_CCW_KEY { {5, 5} } |
There was a problem hiding this comment.
This should be removed completely, in favor of encoder map support.
github-actions
bot
added
the
via
drashna
reviewed
Aug 31, 2022
drashna
approved these changes
Aug 31, 2022
keyboard-magpie
approved these changes
Aug 31, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
by 3araht
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rotary encoder setting revised to solve a malfunction. (an update of Asymmetric encoders, encoder tests. (Asymmetric encoders, encoder tests. #16068) is applied.)
A minor update on a keymap.
Types of Changes
Issues Fixed or Closed by This PR
Checklist