[Core] Refactor writePin to work with statements #16738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ternary operator expects expressions as its arguments, this works for most gpio implementations but not for the RP2040 port as the gpio macros are implemented as statements. Therefore the ternary operator is replaced with a wrapped if-else statement which does accept simple statements.
35 tasks
zvecr
approved these changes
Mar 27, 2022
drashna
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ternary operator expects expressions as its arguments, this works for most gpio implementations but not for the RP2040 port as the gpio macros are implemented as statements. Using
writePinwould error on Macro expansion during compilation. See #14877 (comment)Therefore the ternary operator is replaced with a wrapped if-else statement which does accept simple statements.
Types of Changes
Issues Fixed or Closed by This PR
writePinChecklist