Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up LED/RGB Matrix driver config #14760

Merged
merged 3 commits into from
Oct 10, 2021
Merged

Clean up LED/RGB Matrix driver config #14760

merged 3 commits into from
Oct 10, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 9, 2021

Description

  • Reorganised led_matrix_drivers.c/rgb_matrix_drivers.c, so that DRIVER_ADDR_2 is required to be defined in order to use DRIVER_ADDR_3, etc.
  • Removed duplicate driver addresses in keyboard code ("this is here for compliancy reasons")

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 9, 2021 04:42
@fauxpark fauxpark mentioned this pull request Oct 9, 2021
Merged
13 tasks
@drashna drashna requested a review from a team October 9, 2021 08:36
@fauxpark fauxpark requested a review from sigprof October 10, 2021 00:30
@drashna drashna merged commit b487e10 into qmk:develop Oct 10, 2021
@fauxpark fauxpark deleted the led-rgb-driver-cleanup branch October 11, 2021 00:26
@fauxpark fauxpark mentioned this pull request Oct 11, 2021
Merged
14 tasks
MasterSpoon added a commit to MasterSpoon/qmk_firmware that referenced this pull request Oct 31, 2021
@MasterSpoon
update to match qmk#14760
3d8b74d 
reformatted led / rgb matrix drivers inline with pull request qmk#14760
@MasterSpoon MasterSpoon mentioned this pull request Oct 31, 2021
Merged
14 tasks
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@fauxpark @ptrxyz
Clean up LED/RGB Matrix driver config (qmk#14760)
0ed81dc
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Clean up LED/RGB Matrix driver config (qmk#14760)
7ffa23c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@sigprof sigprof sigprof approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @sigprof @drashna