-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Parse USB device version BCD #14580
Conversation
There are a handful of boards with
|
Last failing test is expected, due to the boards listed above which have invalid digits. |
3409538
to
ae19df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can fix up the conflicts, this can go in.
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm not sure what you mean. You can see here, and in the actual USB spec, that this value is indeed BCD and should be treated as such: https://www.beyondlogic.org/usbnutshell/usb5.shtml#DeviceDescriptors Therefore, digits greater than 9 are not allowed. |
Description
DEVICE_VER
is a BCD value in the formatMMmr
. This enhances the mapping betweeninfo.json
andconfig.h
from a simple 4 digit hex number to a version string.Types of Changes
Issues Fixed or Closed by This PR
Checklist