Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to add SPRH keyboard to QMK #12999

Merged
merged 170 commits into from
Jul 22, 2021
Merged

Pull request to add SPRH keyboard to QMK #12999

merged 170 commits into from
Jul 22, 2021

Conversation

joedinkle
Copy link
Contributor

Description

Changes would add the SPRH keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [X ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@joedinkle joedinkle requested a review from drashna June 2, 2021 00:57
@drashna
Copy link
Member

drashna commented Jun 7, 2021

You have a merge conflict that needs to be resolved.

@joedinkle
Copy link
Contributor Author

You have a merge conflict that needs to be resolved.

Fixed

keyboards/eyeohdesigns/sprh/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/keymaps/split/keymap.c Outdated Show resolved Hide resolved
@joedinkle
Copy link
Contributor Author

I'm still working on this. Dealing with a busy work schedule and some QMK version compatibility issues. Should have things resolved soon.

@joedinkle
Copy link
Contributor Author

Suggested changes were made to all keymaps.

@joedinkle joedinkle requested a review from drashna July 20, 2021 13:42
@drashna drashna requested a review from a team July 20, 2021 16:18
keyboards/eyeohdesigns/sprh/rules.mk Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/readme.md Outdated Show resolved Hide resolved
keyboards/eyeohdesigns/sprh/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 20, 2021 17:47
@joedinkle
Copy link
Contributor Author

Requested changes made.

@joedinkle joedinkle requested review from fauxpark and removed request for a team July 20, 2021 21:54
@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit e9c3f71 into qmk:master Jul 22, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants