Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable media keys support for Canoe VIA keymap #10829

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Enable media keys support for Canoe VIA keymap #10829

merged 1 commit into from
Nov 2, 2020

Conversation

Frothy
Copy link
Contributor

@Frothy Frothy commented Nov 2, 2020 •
edited
Loading

Description

Enable media keys support to Canoe VIA keymap. This works now thanks to #9650

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Nov 2, 2020
@Frothy Frothy changed the title Enable media keys support to Canoe VIA keymap Enable media keys support for Canoe VIA keymap Nov 2, 2020
@drashna drashna requested a review from a team November 2, 2020 03:11
@fauxpark fauxpark merged commit 75201c7 into qmk:master Nov 2, 2020
@fauxpark
Copy link
Member

fauxpark commented Nov 2, 2020

Thanks!

oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@Frothy
Enable media keys support for Canoe VIA keymap (qmk#10829)
56bea83
ringmaster pushed a commit to ringmaster/qmk_firmware that referenced this pull request Nov 5, 2020
@Frothy
Enable media keys support for Canoe VIA keymap (qmk#10829)
7bb95d7
barrettclark pushed a commit to barrettclark/qmk_firmware that referenced this pull request Nov 5, 2020
Merge remote-tracking branch 'upstream/master'
727ebc8 
* upstream/master: (153 commits)
  [Keymap] add brandonschlack userspace and keymaps (qmk#10411)
  [Keymap] add ai03/polaris:mekberg (qmk#10508)
  CLI: Add `qmk clean` (qmk#10785)
  Adds support for XD84 Pro (qmk#9750)
  Freyr refactor (qmk#10833)
  KC60 refactor (qmk#10834)
  [Keyboard] Fixes for PloopyCo mouse and readmes (qmk#10841)
  Enable extrakeys, mousekeys for all VIA keymaps. (qmk#10740)
  Add OLED support for Riblee F411 (qmk#10778)
  NK65 eeprom compatibility with 128KB and 256KB (qmk#10804)
  Add support for Noxary Vulcan (qmk#10822)
  Enable media keys support for Canoe VIA keymap (qmk#10829)
  Phantom refactor (qmk#10805)
  `qmk info`: Add `--ascii` flag (qmk#10793)
  [Keymap] Corrected the dvorak layout for kinesis advantage (qmk#10808)
  [Keyboard] Fix keyboard matrix scan rate with F072 (qmk#10226)
  [Keyboard] nullbitsco/nibble Configurator rework (qmk#10814)
  [Keyboard] VIA Support: Exent 65% (qmk#10797)
  [Keyboard] Add keebsforall/freebird60 (qmk#10774)
  add 65_ansi_split_bs to default community layouts (qmk#10770)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frothy @fauxpark @drashna