Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circleci/docker #17

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Circleci/docker #17

merged 1 commit into from
Nov 8, 2017

Conversation

qlikmats
Copy link
Contributor

Fixes #[issue number].

Status

[ ] Under development
[ ] Waiting for code review
[ ] Waiting for merge

Information

[ ] Contains breaking changes
[ ] Contains new API(s)
[ ] Contains documentation
[ ] Contains test
[ ] Contains examples

To-do list

[ ] [Fix this thing]
[ ] [Fix another thing]
[ ] ...

@tobiaslindulf
Copy link
Contributor

I think it would be good to have a very short description about how to run the docker images in this md file, mostly so that people knows why they exist: https://github.com/qlik-oss/server-side-extension/blob/circleci/docker/examples/python/GetStarted.md

tobiaslindulf
tobiaslindulf approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@tobiaslindulf tobiaslindulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@qlikmats qlikmats merged commit 24da74e into master Nov 8, 2017
@qlikmats qlikmats deleted the circleci/docker branch November 9, 2017 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefinestal josefinestal josefinestal approved these changes

@tobiaslindulf tobiaslindulf tobiaslindulf approved these changes

@kjartan-qlik kjartan-qlik Awaiting requested review from kjartan-qlik

@sam-sla sam-sla Awaiting requested review from sam-sla

@qlik-aoh qlik-aoh Awaiting requested review from qlik-aoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qlikmats @tobiaslindulf @josefinestal @mjacobsson