Use custom ReadAll using globalbuffer for communication (#507)

* Move ReadAll function using global pool buffer to helpers
* Use ReadAll function instead of io.ReadAll for decrease memory allocation for REST handler and WS communication.

helpers/BufferPool.go

@@ -2,6 +2,7 @@ package helpers
 
 import (
 	"bytes"
+	"io"
 	"sync"
 )
 
@@ -29,3 +30,29 @@ func (bp *BufferPool) Put(buf *bytes.Buffer) {
 	buf.Reset()
 	bp.pool.Put(buf)
 }
+
+func ReadAll(r io.Reader) ([]byte, error) {
+	buf := GlobalBufferPool.Get()
+	defer GlobalBufferPool.Put(buf)
+
+	capacity := int64(bytes.MinRead)
+	var err error
+	// If the buffer overflows, we will get bytes.ErrTooLarge.
+	// Return that as an error. Any other panic remains.
+	defer func() {
+		e := recover()
+		if e == nil {
+			return
+		}
+		if panicErr, ok := e.(error); ok && panicErr == bytes.ErrTooLarge {
+			err = panicErr
+		} else {
+			panic(e)
+		}
+	}()
+	if int64(int(capacity)) == capacity {
+		buf.Grow(int(capacity))
+	}
+	_, err = buf.ReadFrom(r)
+	return buf.Bytes(), err
+}

session/resthandler.go

@@ -648,7 +648,7 @@ func (handler *RestHandler) QueueRequestWithCallback(actionState *action.State,
 			request.ResponseStatus = request.response.Status
 			request.ResponseStatusCode = request.response.StatusCode
 			request.ResponseHeaders = request.response.Header
-			request.ResponseBody, errRequest = io.ReadAll(request.response.Body)
+			request.ResponseBody, errRequest = helpers.ReadAll(request.response.Body)
 			// When content type is a stream normal metric log will be time to response without starting to stream the body. Thus this will log response time to stream end
 			if logEntry.ShouldLogTrafficMetrics() && strings.HasPrefix(request.response.Header.Get("Content-Type"), "text/event-stream") {
 				logEntry.LogTrafficMetric(time.Since(doTs).Nanoseconds(), 0, uint64(len(request.ResponseBody)), -1, req.URL.Path, "", "STREAM", "")
@@ -671,32 +671,6 @@ func (handler *RestHandler) addVirtualProxy(request *RestRequest) error {
 	return nil
 }
 
-func ReadAll(r io.Reader) ([]byte, error) {
-	buf := helpers.GlobalBufferPool.Get()
-	defer helpers.GlobalBufferPool.Put(buf)
-
-	capacity := int64(bytes.MinRead)
-	var err error
-	// If the buffer overflows, we will get bytes.ErrTooLarge.
-	// Return that as an error. Any other panic remains.
-	defer func() {
-		e := recover()
-		if e == nil {
-			return
-		}
-		if panicErr, ok := e.(error); ok && panicErr == bytes.ErrTooLarge {
-			err = panicErr
-		} else {
-			panic(e)
-		}
-	}()
-	if int64(int(capacity)) == capacity {
-		buf.Grow(int(capacity))
-	}
-	_, err = buf.ReadFrom(r)
-	return buf.Bytes(), err
-}
-
 func prependURLPath(aURL, pathToPrepend string) (string, error) {
 	urlObj, err := url.Parse(aURL)
 	if err != nil {

wsdialer/wsdialer.go

@@ -191,7 +191,7 @@ func readMessage(r io.Reader, m []wsutil.Message, maxFrameSize int64) ([]wsutil.
 		State:     gobwas.StateClientSide,
 		CheckUTF8: true,
 		OnIntermediate: func(hdr gobwas.Header, src io.Reader) error {
-			bts, err := io.ReadAll(src)
+			bts, err := helpers.ReadAll(src)
 			if err != nil {
 				return err
 			}